Open AI panel when AI app generator starts generating #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jurgenwerk
commented
Dec 27, 2024
| @@ -622,7 +623,7 @@ module('Acceptance | Commands tests', function (hooks) { | |||
| assert.dom('[data-test-card-url-bar-input]').hasValue(`${testCard}.json`); | |||
| await click('[data-test-submode-switcher] button'); | |||
| await click('[data-test-boxel-menu-item-text="Interact"]'); | |||
| await click('[data-test-open-ai-assistant]'); | |||
There was a problem hiding this comment.
The behavior changed now that I moved the aiAssistantOpen from the component to the state service–previously, if the AI panel was open and the user toggled from interactive to code mode and then back to interactive, the AI panel was closed. But now, the AI panel remains open when going back to interactive mode. I think this behavior is actually more desirable, let me know if you think otherwise.
lukemelia
requested changes
Dec 27, 2024
|
I added a new command for the purpose of opening an AI assistant room. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the following:
experimentalAIEnabledflag - I believe this is not experimental anymorecurrentRoomIdandaiAssistantOpenfrom component state to matrix and operator mode state services so that we can manipulate them from other parts of the appopenRoomcommandHere in this video you can see the AI panel opens when user clicks on "Let's get started":
Screen.Recording.2024-12-27.at.13.24.06.mov